Fix a memory issue that check -tabular uses too much memory with many revisions

The call to GetSnapshotChunks in ShowStatisticsTabular sets keepChunkHashes to
true -- this can cause too much memory consumption with hundreds of revisions.
This commit is contained in:
Gilbert Chen
2019-04-20 22:47:03 -04:00
parent abcb4d75c1
commit 4b69c1162e

View File

@@ -998,7 +998,7 @@ func (manager *SnapshotManager) ShowStatisticsTabular(snapshotMap map[string][]*
earliestSeenChunks := make(map[string]int) earliestSeenChunks := make(map[string]int)
for _, snapshot := range snapshotList { for _, snapshot := range snapshotList {
for _, chunkID := range manager.GetSnapshotChunks(snapshot, true) { for _, chunkID := range manager.GetSnapshotChunks(snapshot, false) {
if earliestSeenChunks[chunkID] == 0 { if earliestSeenChunks[chunkID] == 0 {
earliestSeenChunks[chunkID] = math.MaxInt32 earliestSeenChunks[chunkID] = math.MaxInt32
} }
@@ -1009,7 +1009,7 @@ func (manager *SnapshotManager) ShowStatisticsTabular(snapshotMap map[string][]*
for _, snapshot := range snapshotList { for _, snapshot := range snapshotList {
chunks := make(map[string]bool) chunks := make(map[string]bool)
for _, chunkID := range manager.GetSnapshotChunks(snapshot, true) { for _, chunkID := range manager.GetSnapshotChunks(snapshot, false) {
chunks[chunkID] = true chunks[chunkID] = true
snapshotChunks[chunkID] = true snapshotChunks[chunkID] = true
} }